Files
@ 260a7a01b054
Branch filter:
Location: kallithea/rhodecode/templates/admin/notifications/notifications_data.html - annotation
260a7a01b054
1.4 KiB
text/html
follow Python conventions for boolean values
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
2aee0dc1784e 523b1011a625 2aee0dc1784e 2aee0dc1784e 2aee0dc1784e 8ee72933405f 64f7cf8f6a33 64f7cf8f6a33 64f7cf8f6a33 64f7cf8f6a33 64f7cf8f6a33 64f7cf8f6a33 c25cc1c7c65f 64f7cf8f6a33 64f7cf8f6a33 64f7cf8f6a33 64f7cf8f6a33 64f7cf8f6a33 64f7cf8f6a33 64f7cf8f6a33 3fdf7c3be2c9 3fdf7c3be2c9 3fdf7c3be2c9 d5e42c00f3c1 3fdf7c3be2c9 64f7cf8f6a33 64f7cf8f6a33 64f7cf8f6a33 64f7cf8f6a33 64f7cf8f6a33 64f7cf8f6a33 64f7cf8f6a33 64f7cf8f6a33 83aff72a1da7 64f7cf8f6a33 64f7cf8f6a33 64f7cf8f6a33 2aee0dc1784e 2aee0dc1784e f91d3f9b7230 |
%if c.notifications:
<%
unread = lambda n:{False:'unread'}.get(n)
%>
<div class="notification-list notification-table">
%for notification in c.notifications:
<div id="notification_${notification.notification.notification_id}" class="container ${unread(notification.read)}">
<div class="notification-header">
<div class="gravatar">
<img alt="gravatar" src="${h.gravatar_url(h.email_or_none(notification.notification.created_by_user.email),24)}"/>
</div>
<div class="desc ${unread(notification.read)}">
<a href="${url('notification', notification_id=notification.notification.notification_id)}">${notification.notification.description}</a>
</div>
<div class="delete-notifications">
<span id="${notification.notification.notification_id}" class="delete-notification delete_icon action"></span>
</div>
%if not notification.read:
<div class="read-notifications">
<span id="${notification.notification.notification_id}" class="read-notification accept_icon action"></span>
</div>
%endif
</div>
<div class="notification-subject">${h.literal(notification.notification.subject)}</div>
</div>
%endfor
</div>
<div class="notification-paginator">
<div class="pagination-wh pagination-left">
${c.notifications.pager('$link_previous ~2~ $link_next',**request.GET.mixed())}
</div>
</div>
%else:
<div class="table">${_('No notifications here yet')}</div>
%endif
|