Files
@ 260a7a01b054
Branch filter:
Location: kallithea/rhodecode/templates/admin/notifications/show_notification.html - annotation
260a7a01b054
1.9 KiB
text/html
follow Python conventions for boolean values
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
cac5109ac3b6 cac5109ac3b6 cac5109ac3b6 cac5109ac3b6 1f334a68d057 cac5109ac3b6 cac5109ac3b6 cac5109ac3b6 cac5109ac3b6 f91d3f9b7230 cac5109ac3b6 cac5109ac3b6 cac5109ac3b6 cac5109ac3b6 cac5109ac3b6 cac5109ac3b6 cac5109ac3b6 cac5109ac3b6 cac5109ac3b6 cac5109ac3b6 cac5109ac3b6 f91d3f9b7230 93d4e3eb7d84 93d4e3eb7d84 93d4e3eb7d84 93d4e3eb7d84 93d4e3eb7d84 cac5109ac3b6 cac5109ac3b6 7ff304d3028f 7ff304d3028f 7ff304d3028f c25cc1c7c65f 7ff304d3028f 7ff304d3028f 7ff304d3028f 7ff304d3028f 7ff304d3028f 7ff304d3028f 7ff304d3028f cac5109ac3b6 f60a07dbe2f0 f60a07dbe2f0 f60a07dbe2f0 f60a07dbe2f0 f60a07dbe2f0 f60a07dbe2f0 cac5109ac3b6 cac5109ac3b6 cac5109ac3b6 cac5109ac3b6 cac5109ac3b6 7ff304d3028f cac5109ac3b6 cac5109ac3b6 7ff304d3028f cac5109ac3b6 cac5109ac3b6 f91d3f9b7230 | ## -*- coding: utf-8 -*-
<%inherit file="/base/base.html"/>
<%def name="title()">
${_('Show notification')} ${c.rhodecode_user.username} · ${c.rhodecode_name}
</%def>
<%def name="breadcrumbs_links()">
${h.link_to(_('Notifications'),h.url('notifications'))}
»
${_('Show notification')}
</%def>
<%def name="page_nav()">
${self.menu('admin')}
</%def>
<%def name="main()">
<div class="box">
<!-- box / title -->
<div class="title">
${self.breadcrumbs()}
##<ul class="links">
## <li>
## <span style="text-transform: uppercase;"><a href="#">${_('Compose message')}</a></span>
## </li>
##</ul>
</div>
<div class="table">
<div id="notification_${c.notification.notification_id}">
<div class="notification-header">
<div class="gravatar">
<img alt="gravatar" src="${h.gravatar_url(h.email_or_none(c.notification.created_by_user.email),24)}"/>
</div>
<div class="desc">
${c.notification.description}
</div>
<div class="delete-notifications">
<span id="${c.notification.notification_id}" class="delete-notification delete_icon action"></span>
</div>
</div>
<div class="notification-body">
<div class="notification-subject">${h.literal(c.notification.subject)}</div>
%if c.notification.body:
${h.rst_w_mentions(c.notification.body)}
%endif
</div>
</div>
</div>
</div>
<script type="text/javascript">
var url = "${url('notification', notification_id='__NOTIFICATION_ID__')}";
var main = "${url('notifications')}";
YUE.on(YUQ('.delete-notification'),'click',function(e){
var notification_id = e.currentTarget.id;
deleteNotification(url,notification_id,[function(){window.location=main}])
})
</script>
</%def>
|