Files
@ 260a7a01b054
Branch filter:
Location: kallithea/rhodecode/templates/bookmarks/bookmarks.html - annotation
260a7a01b054
2.1 KiB
text/html
follow Python conventions for boolean values
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
a3ee2611e6e8 a3ee2611e6e8 a3ee2611e6e8 a3ee2611e6e8 1f334a68d057 a3ee2611e6e8 a3ee2611e6e8 a3ee2611e6e8 a3ee2611e6e8 9e677f6d34cb a3ee2611e6e8 a3ee2611e6e8 a3ee2611e6e8 eacd33e0c5b3 a3ee2611e6e8 51da0e019248 a3ee2611e6e8 51da0e019248 a3ee2611e6e8 a3ee2611e6e8 a3ee2611e6e8 a3ee2611e6e8 a3ee2611e6e8 a3ee2611e6e8 a3ee2611e6e8 a3ee2611e6e8 a3ee2611e6e8 a3ee2611e6e8 51da0e019248 a3ee2611e6e8 eaf09acf6872 eaf09acf6872 eaf09acf6872 eaf09acf6872 eaf09acf6872 eaf09acf6872 eaf09acf6872 eaf09acf6872 eaf09acf6872 eaf09acf6872 eaf09acf6872 eaf09acf6872 eaf09acf6872 eaf09acf6872 eaf09acf6872 eaf09acf6872 eaf09acf6872 eaf09acf6872 eaf09acf6872 eaf09acf6872 eaf09acf6872 eaf09acf6872 eaf09acf6872 eaf09acf6872 eaf09acf6872 eaf09acf6872 eaf09acf6872 eaf09acf6872 eaf09acf6872 eaf09acf6872 eaf09acf6872 f91d3f9b7230 eaf09acf6872 eaf09acf6872 eaf09acf6872 eaf09acf6872 eaf09acf6872 eaf09acf6872 eaf09acf6872 f91d3f9b7230 f91d3f9b7230 eaf09acf6872 a3ee2611e6e8 eaf09acf6872 eaf09acf6872 f91d3f9b7230 | ## -*- coding: utf-8 -*-
<%inherit file="/base/base.html"/>
<%def name="title()">
${_('%s Bookmarks') % c.repo_name} · ${c.rhodecode_name}
</%def>
<%def name="breadcrumbs_links()">
<input class="q_filter_box" id="q_filter_bookmarks" size="15" type="text" name="filter" value="${_('quick filter...')}"/>
${_('Bookmarks')}
</%def>
<%def name="page_nav()">
${self.menu('repositories')}
</%def>
<%def name="main()">
${self.context_bar('switch-to')}
<div class="box">
<!-- box / title -->
<div class="title">
${self.breadcrumbs()}
</div>
<!-- end box / title -->
<div class="table">
<%include file='bookmarks_data.html'/>
</div>
</div>
<script type="text/javascript">
// main table sorting
var myColumnDefs = [
{key:"name",label:"${_('Name')}",sortable:true},
{key:"date",label:"${_('Date')}",sortable:true,
sortOptions: { sortFunction: dateSort }},
{key:"author",label:"${_('Author')}",sortable:true},
{key:"revision",label:"${_('Revision')}",sortable:true,
sortOptions: { sortFunction: revisionSort }},
];
var myDataSource = new YAHOO.util.DataSource(YUD.get("bookmarks_data"));
myDataSource.responseType = YAHOO.util.DataSource.TYPE_HTMLTABLE;
myDataSource.responseSchema = {
fields: [
{key:"name"},
{key:"date"},
{key:"author"},
{key:"revision"},
]
};
var myDataTable = new YAHOO.widget.DataTable("table_wrap", myColumnDefs, myDataSource,
{
sortedBy:{key:"name",dir:"asc"},
MSG_SORTASC:"${_('Click to sort ascending')}",
MSG_SORTDESC:"${_('Click to sort descending')}",
MSG_EMPTY:"${_('No records found.')}",
MSG_ERROR:"${_('Data error.')}",
MSG_LOADING:"${_('Loading...')}",
}
);
myDataTable.subscribe('postRenderEvent',function(oArgs) {
tooltip_activate();
var func = function(node){
return node.parentNode.parentNode.parentNode.parentNode.parentNode;
}
q_filter('q_filter_bookmarks',YUQ('div.table tr td .logbooks .bookbook a'),func);
});
</script>
</%def>
|