Files
@ 260a7a01b054
Branch filter:
Location: kallithea/rhodecode/templates/bookmarks/bookmarks_data.html - annotation
260a7a01b054
1.2 KiB
text/html
follow Python conventions for boolean values
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
eaf09acf6872 f91d3f9b7230 eaf09acf6872 c20adbaf16af b4f401524060 eaf09acf6872 eaf09acf6872 eaf09acf6872 eaf09acf6872 b4f401524060 c20adbaf16af c20adbaf16af b4f401524060 a3ee2611e6e8 a3ee2611e6e8 a3ee2611e6e8 184557472f5c a3ee2611e6e8 184557472f5c f467c75544af b4f401524060 b4f401524060 184557472f5c 184557472f5c 184557472f5c f91d3f9b7230 b4f401524060 c20adbaf16af a3ee2611e6e8 eaf09acf6872 a3ee2611e6e8 b4f401524060 f91d3f9b7230 | %if c.repo_bookmarks:
<div id="table_wrap" class="yui-skin-sam">
<table id="bookmarks_data">
<thead>
<tr>
<th class="left">${_('Name')}</th>
<th class="left">${_('Date')}</th>
<th class="left">${_('Author')}</th>
<th class="left">${_('Revision')}</th>
</tr>
</thead>
%for cnt,book in enumerate(c.repo_bookmarks.items()):
<tr class="parity${cnt%2}">
<td>
<span class="logbooks">
<span class="bookbook">${h.link_to(book[0],
h.url('files_home',repo_name=c.repo_name,revision=book[1].raw_id))}</span>
</span>
</td>
<td><span class="tooltip" title="${h.tooltip(h.age(book[1].date))}">${h.fmt_date(book[1].date)}</span></td>
<td title="${book[1].author}">${h.person(book[1].author)}</td>
<td>
<div>
<pre><a href="${h.url('files_home',repo_name=c.repo_name,revision=book[1].raw_id)}">r${book[1].revision}:${h.short_id(book[1].raw_id)}</a></pre>
</div>
</td>
</tr>
%endfor
</table>
</div>
%else:
${_('There are no bookmarks yet')}
%endif
|