# HG changeset patch
# User Ross Thomas <ross@lns-nevasoft.com>
# Date 2020-02-12 14:37:15
# Node ID 85135d4f9feff9aabb30399cc7ba24ade09dc589
# Parent  8169770a4f2c967d4c41aca7c7fb31e90fbec989

ui: fix page navigation/scrolling when toggling "Follow" status

The onclick handler was a void function and thus not cancelling the default
handling of following the 'href'.

The called toggleFollowingRepo function was already returning false, so the
onClick handler just needs to return the result of the called function.

diff --git a/kallithea/templates/base/base.html b/kallithea/templates/base/base.html
--- a/kallithea/templates/base/base.html
+++ b/kallithea/templates/base/base.html
@@ -163,7 +163,7 @@
               ## also it feels like a job for the controller
               %if request.authuser.username != 'default':
                   <li>
-                   <a href="#" class="${'following' if c.repository_following else 'follow'}" onclick="toggleFollowingRepo(this, ${c.db_repo.repo_id});">
+                   <a href="#" class="${'following' if c.repository_following else 'follow'}" onclick="return toggleFollowingRepo(this, ${c.db_repo.repo_id});">
                     <span class="show-follow"><i class="icon-heart-empty"></i>${_('Follow')}</span>
                     <span class="show-following"><i class="icon-heart"></i>${_('Unfollow')}</span>
                    </a>