# HG changeset patch # User Thomas De Schampheleire # Date 2020-09-25 11:11:11 # Node ID 96c86063278c85e119b3f093fd1c5a219ccbf774 # Parent a86569aef60025742fc18903a51bb1e7aa5dbcdb autocomplete: also match on email address There are cases where the firstname/lastname known to Kallithea, is not complete, perhaps only an initial. But users that try to add a reviewer, may start typing a full name and expect autocompletion. For example: firstname: John lastname: D email: john.doe@example.com When a review starts typing 'Doe' they will not get any matches if autocompletion is purely based on names. This situation sometimes arises with Indian developers, where the names known to companies may be abbreviated as initials. For example "C K Deepak" where Deepak is the first name and C K are the initials of the last name. diff --git a/kallithea/controllers/home.py b/kallithea/controllers/home.py --- a/kallithea/controllers/home.py +++ b/kallithea/controllers/home.py @@ -174,6 +174,7 @@ class HomeController(BaseController): User.username.ilike("%%" + query + "%%"), User.name.concat(' ').concat(User.lastname).ilike("%%" + query + "%%"), User.lastname.concat(' ').concat(User.name).ilike("%%" + query + "%%"), + User.email.ilike("%%" + query + "%%"), )) \ .order_by(User.username) \ .limit(500) \