# HG changeset patch
# User Mads Kiilerich <mads@kiilerich.com>
# Date 2021-02-22 12:12:38
# Node ID ba7c0397c3c197f945fe32632605495f057e0284
# Parent  99ffd118f6af1935b812e2e7c154feb7c7b050e8

comments: don't open comment form on page load for comments on line 0

Data attributes have magic parsing of strings so '0' becomes 0 which is false.

Further, 0 == '' in JavaScript, so we have to use !== '' to catch empty strings.

diff --git a/kallithea/public/js/base.js b/kallithea/public/js/base.js
--- a/kallithea/public/js/base.js
+++ b/kallithea/public/js/base.js
@@ -528,7 +528,7 @@ function move_comments($anchorcomments) 
         var line_no = $anchorcomment.data('line_no');
         if ($comment_div[0]) {
             $comment_div.append($anchorcomment.children());
-            if (f_path && line_no) {
+            if (f_path && line_no !== '') {
                 _comment_div_append_add($comment_div, f_path, line_no);
             } else {
                 _comment_div_append_form($comment_div, f_path, line_no);