# HG changeset patch # User Mads Kiilerich # Date 2014-08-31 14:44:54 # Node ID bbf4118f6e0f21c62439f2e108c225d24dc05d9e # Parent 3b082ec6fd8b396914bf96312e9000efb96b7ee8 git: fix "'name' must be bytestring, not unicode" error on browsing changesets Adding some extra safe_str to address https://bitbucket.org/conservancy/kallithea/issue/24/clicking-on-changesets-results-in-a-500 seems consistent with existing code. diff --git a/kallithea/lib/vcs/backends/git/changeset.py b/kallithea/lib/vcs/backends/git/changeset.py --- a/kallithea/lib/vcs/backends/git/changeset.py +++ b/kallithea/lib/vcs/backends/git/changeset.py @@ -27,11 +27,11 @@ class GitChangeset(BaseChangeset): def __init__(self, repository, revision): self._stat_modes = {} self.repository = repository - + revision = safe_str(revision) try: - commit = self.repository._repo[str(revision)] + commit = self.repository._repo[revision] if isinstance(commit, objects.Tag): - revision = commit.object[1] + revision = safe_str(commit.object[1]) commit = self.repository._repo.get_object(commit.object[1]) except KeyError: raise RepositoryError("Cannot get object with id %s" % revision)