# HG changeset patch
# User Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
# Date 2020-05-23 20:24:07
# Node ID c76eb3a60f6f1fddee75810a0e6b7b1e4aec07d2
# Parent  3dfe049ec96538faf6aeac6b6276744b5c363133

tests: actually test something useful in test_edit for gists (Issue #376)

Even though there was a test for editing gists, it did not catch the basic
loading problem reported in issue #376. In fact, the test just loaded the
edit page, but since no user was actually logged in, it just loaded the
login screen. As a result, no real gist editing code was tested at all.

Instead, explicitly check the redirection to a login screen, then proceed
with logging in and check that the edit page can be loaded.

Additionally, don't rely on the magic gist id '1' but create an actual gist
first.

Note: the test does not yet really edit a gist.

diff --git a/kallithea/tests/functional/test_admin_gists.py b/kallithea/tests/functional/test_admin_gists.py
--- a/kallithea/tests/functional/test_admin_gists.py
+++ b/kallithea/tests/functional/test_admin_gists.py
@@ -168,4 +168,11 @@ class TestGistsController(base.TestContr
         assert response.body == b'GIST BODY'
 
     def test_edit(self):
-        response = self.app.get(base.url('edit_gist', gist_id=1))
+        gist = _create_gist('gist-edit')
+        response = self.app.get(base.url('edit_gist', gist_id=gist.gist_access_id), status=302)
+        assert 'login' in response.location
+
+        self.log_user(base.TEST_USER_REGULAR_LOGIN, base.TEST_USER_REGULAR_PASS)
+        response = self.app.get(base.url('edit_gist', gist_id=gist.gist_access_id))
+
+        # FIXME actually test editing the gist