# HG changeset patch # User Jan Heylen # Date 2015-03-19 13:13:06 # Node ID d053efba3c0c922cc4fadae11dabb4db084cd8e1 # Parent 9c252005e5fd69efd579b410f1160b42b183c8cf pullrequests: saving raw_id instead of branch in org_ref This fixes an issue when the pull request is created while the top commit included is not the tip. In that case, the faulty code would but branch:default:default as org_ref, that causes the pull request view to show all commits on that branch instead of the wanted commit(s) only. The fix will result in a branch:default:1234567890abcdef1234567890abcdef (e.g) diff --git a/kallithea/controllers/pullrequests.py b/kallithea/controllers/pullrequests.py --- a/kallithea/controllers/pullrequests.py +++ b/kallithea/controllers/pullrequests.py @@ -322,8 +322,8 @@ class PullrequestsController(BaseRepoCon org_rev) = org_ref.split(':') if org_ref_type == 'rev': org_ref_type = 'branch' - org_ref_name = org_repo.scm_instance.get_changeset(org_rev).branch - org_ref = '%s:%s:%s' % (org_ref_type, org_ref_name, org_ref_name) + cs = org_repo.scm_instance.get_changeset(org_rev) + org_ref = '%s:%s:%s' % (org_ref_type, cs.branch, cs.raw_id) other_repo_name = _form['other_repo'] other_ref = _form['other_ref'] # will have symbolic name and head revision