kallithea Changeset - 335f7f13b934

Changeset - 335f7f13b934

Parent rev.

Child rev.

[Not reviewed]

stable

0 1 0

Mads Kiilerich (mads) - 2 months ago 2026-01-06 21:53:43
mads@kiilerich.com

tests: try harder to prevent Git from reading external configuration

Tests would fail if ~/.gitconfig contained for example:

[init]
defaultBranch = main

Setting GIT_CONFIG_GLOBAL=/dev/null prevents Git from reading ~/.gitconfig ...
but isn't support by Dulwich and doesn't solve the problem.

We will thus work around this issue by setting HOME to the temp test location.
That will prevent Dulwich from reading configuration files by making
os.path.expanduser point to a location with known content.

We also set XDG_CONFIG_HOME to avoid reading ~/.config/git/config .

Setting GIT_CONFIG_NOSYSTEM will prevent reading /etc/gitconfig - that seems
like a good idea too.

1 file changed with 4 insertions and 0 deletions:

kallithea/tests/conftest.py

0 comments (0 inline, 0 general)

kallithea/tests/conftest.py

➞

Show inline comments

 import logging
 import os
 import time
 import formencode
 import pytest
 from paste.deploy import loadwsgi
 from pytest_localserver.http import WSGIServer
 from routes.util import URLGenerator
 from tg.util.webtest import test_context
 import kallithea.tests.base  # FIXME: needed for setting testapp instance!!!
 from kallithea.controllers.root import RootController
 from kallithea.lib import inifile
 from kallithea.lib.utils import repo2db_mapper
 from kallithea.model import db, meta
 from kallithea.model.scm import ScmModel
 from kallithea.model.user import UserModel
 from kallithea.tests.base import TEST_USER_ADMIN_LOGIN, TEST_USER_ADMIN_PASS, TEST_USER_REGULAR_LOGIN, TESTS_TMP_PATH, invalidate_all_caches
 from kallithea.tests.fixture import create_test_env, create_test_index
 def pytest_configure():
     os.environ['TZ'] = 'UTC'
     if not kallithea.is_windows:
         time.tzset() # only available on Unix
     os.environ['HOME'] = TESTS_TMP_PATH
     os.environ['XDG_CONFIG_HOME'] = TESTS_TMP_PATH + '/.config'
     os.environ['GIT_CONFIG_NOSYSTEM'] = '1'
     # Disable INFO logging of test database creation, restore with NOTSET
     logging.disable(logging.INFO)
     ini_settings = {
         '[server:main]': {
             'port': '4999',
         },
         '[app:main]': {
             'ssh_enabled': 'true',
             # Mainly to safeguard against accidentally overwriting the real one:
             'ssh_authorized_keys': os.path.join(TESTS_TMP_PATH, 'authorized_keys'),
             #'ssh_locale': 'C',
             'app_instance_uuid': 'test',
             'show_revision_number': 'true',
             'session.secret': '{74e0cd75-b339-478b-b129-07dd221def1f}',
             #'i18n.lang': '',
         },
         '[handler_console]': {
             'formatter': 'color_formatter',
         },
         # The 'handler_console_sql' block is very similar to the one in
         # development.ini, but without the explicit 'level=DEBUG' setting:
         # it causes duplicate sqlalchemy debug logs, one through
         # handler_console_sql and another through another path.
         '[handler_console_sql]': {
             'formatter': 'color_formatter_sql',
         },
+    }
     create_database = os.environ.get('TEST_DB')  # TODO: rename to 'CREATE_TEST_DB'
     if create_database:
         ini_settings['[app:main]']['sqlalchemy.url'] = create_database
     reuse_database = os.environ.get('REUSE_TEST_DB')
     if reuse_database:
         ini_settings['[app:main]']['sqlalchemy.url'] = reuse_database
     test_ini_file = os.path.join(TESTS_TMP_PATH, 'test.ini')
     inifile.create(test_ini_file, None, ini_settings)
     context = loadwsgi.loadcontext(loadwsgi.APP, 'config:%s' % test_ini_file)
     # set KALLITHEA_NO_TMP_PATH=1 to disable re-creating the database and test repos
     if not int(os.environ.get('KALLITHEA_NO_TMP_PATH', 0)):
         create_test_env(TESTS_TMP_PATH, context.config(), reuse_database=bool(reuse_database))
     # set KALLITHEA_WHOOSH_TEST_DISABLE=1 to disable whoosh index during tests
     if not int(os.environ.get('KALLITHEA_WHOOSH_TEST_DISABLE', 0)):
         create_test_index(TESTS_TMP_PATH, context.config(), True)

0 comments (0 inline, 0 general)