kallithea Changeset - 68861940ee1e

Changeset - 68861940ee1e

Parent rev.

Child rev.

[Not reviewed]

stable

0 1 0

Thomas De Schampheleire - 6 years ago 2020-05-23 20:35:45
thomas.de_schampheleire@nokia.com

scripts: let validate-commits default to testing the draft changes upto current

1 file changed with 7 insertions and 1 deletions:

scripts/validate-commits

0 comments (0 inline, 0 general)

scripts/validate-commits

➞

Show inline comments

@@ @@ -2,43 +2,49 @@ @@
 # Validate the specified commits against test suite and other checks.
 if [ -n "$VIRTUAL_ENV" ]; then
     echo "Please run this script from outside a virtualenv."
     exit 1
 fi
 if ! hg update --check -q .; then
     echo "Working dir is not clean, please commit/revert changes first."
     exit 1
 fi
 revset=$1
 if [ -z "$revset" ]; then
     echo "Warning: no revisions specified, checking draft changes up to the current one."
     revset='draft() and ancestors(.)'
 fi
 venv=$(mktemp -d kallithea-validatecommits-env-XXXXXX)
 resultfile=$(mktemp kallithea-validatecommits-result-XXXXXX)
 echo > "$resultfile"
 cleanup()
+{
     rm -rf /tmp/kallithea-test*
     rm -rf "$venv"
+}
 finish()
+{
     cleanup
     # print (possibly intermediate) results
     cat "$resultfile"
     rm "$resultfile"
+}
 trap finish EXIT
-for rev in $(hg log -r "$1" -T '{node}\n'); do
+for rev in $(hg log -r "$revset" -T '{node}\n'); do
     hg log -r "$rev"
     hg update "$rev"
     cleanup
     python3 -m venv "$venv"
     source "$venv/bin/activate"
     pip install --upgrade pip setuptools
     pip install -e . -r dev_requirements.txt python-ldap python-pam
     # run-all-cleanup
     if ! scripts/run-all-cleanup ; then
         echo "run-all-cleanup encountered errors!"

0 comments (0 inline, 0 general)