kallithea Changeset - 861ef58bc36e

Changeset - 861ef58bc36e

Parent rev.

Child rev.

[Not reviewed]

default

0 2 0

Chris Rule - 8 years ago 2018-05-01 17:08:36
crule@aegistg.com

auth: add https ability to the crowd auth module (issue #315)

[Thomas De Schampheleire:
- use select iso checkbox to remove need for bool->string conversion
- update tests]

2 files changed with 11 insertions and 0 deletions:

kallithea/lib/auth_modules/auth_crowd.py

kallithea/tests/functional/test_admin_auth_settings.py

0 comments (0 inline, 0 general)

kallithea/lib/auth_modules/auth_crowd.py

➞

Show inline comments

@@ @@ -131,6 +131,8 @@ class CrowdServer(object): @@
 class KallitheaAuthPlugin(auth_modules.KallitheaExternalAuthPlugin):
     def __init__(self):
         self._protocol_values = ["http", "https"]
     @hybrid_property
     def name(self):
@@ @@ -139,6 +141,14 @@ class KallitheaAuthPlugin(auth_modules.K @@
     def settings(self):
         settings = [
+            {
                 "name": "method",
                 "validator": self.validators.OneOf(self._protocol_values),
                 "type": "select",
                 "values": self._protocol_values,
                 "description": "The protocol used to connect to the Atlassian CROWD server.",
                 "formname": "Protocol"
             },
+            {
                 "name": "host",
                 "validator": self.validators.UnicodeString(strip=True),
                 "type": "string",

kallithea/tests/functional/test_admin_auth_settings.py

➞

Show inline comments

@@ @@ -229,6 +229,7 @@ class TestAuthSettingsController(TestCon @@
                        'auth_crowd_app_password': 'secret',
                        'auth_crowd_admin_groups': 'mygroup',
                        'auth_crowd_port': '123',
                        'auth_crowd_method': 'https',
                        'auth_crowd_app_name': 'xyzzy'})
         test_url = url(controller='admin/auth_settings',

0 comments (0 inline, 0 general)