kallithea Changeset - 86bf9873645f

Changeset - 86bf9873645f

Parent rev.

Child rev.

[Not reviewed]

default

0 2 0

Mads Kiilerich (mads) - 5 years ago 2020-10-01 13:23:12
mads@kiilerich.com

Grafted from: 406fd13c3aba

rcextensions: drop unused (and thus misleading) return values

Note that Mercurial only will check the hook exit value for some kinds of
hooks.

2 files changed with 13 insertions and 24 deletions:

kallithea/config/rcextensions/__init__.py

kallithea/lib/hooks.py

0 comments (0 inline, 0 general)

kallithea/config/rcextensions/__init__.py

➞

Show inline comments

@@ @@ -45,13 +45,12 @@ def _crrepohook(*args, **kwargs): @@
      :param enable_statistics:
      :param clone_uri:
      :param fork_id:
      :param group_id:
      :param created_by:
     """
     return 0
 CREATE_REPO_HOOK = _crrepohook
 #==============================================================================
@@ @@ -104,13 +103,12 @@ def _cruserhook(*args, **kwargs): @@
       :param full_name:
       :param active:
       :param password:
       :param emails:
       :param created_by:
     """
     return 0
 CREATE_USER_HOOK = _cruserhook
 #==============================================================================
@@ @@ -133,13 +131,12 @@ def _dlrepohook(*args, **kwargs): @@
      :param clone_uri:
      :param fork_id:
      :param group_id:
      :param deleted_by:
      :param deleted_on:
     """
     return 0
 DELETE_REPO_HOOK = _dlrepohook
 #==============================================================================
@@ @@ -167,13 +164,12 @@ def _dluserhook(*args, **kwargs): @@
       :param full_name:
       :param active:
       :param password:
       :param emails:
       :param deleted_by:
     """
     return 0
 DELETE_USER_HOOK = _dluserhook
 #==============================================================================
@@ @@ -192,13 +188,12 @@ def _pushhook(*args, **kwargs): @@
       :param username: name of user who pushed
       :param ip: ip of who pushed
       :param action: push
       :param repository: repository name
       :param pushed_revs: list of pushed revisions
     """
     return 0
 PUSH_HOOK = _pushhook
 #==============================================================================
@@ @@ -216,10 +211,9 @@ def _pullhook(*args, **kwargs): @@
       :param scm: type of VS 'git' or 'hg'
       :param username: name of user who pulled
       :param ip: ip of who pulled
       :param action: pull
       :param repository: repository name
     """
     return 0
 PULL_HOOK = _pullhook

kallithea/lib/hooks.py

➞

Show inline comments

@@ @@ -98,14 +98,12 @@ def log_pull_action(ui, repo, **kwargs): @@
     callback = getattr(EXTENSIONS, 'PULL_HOOK', None)
     if callable(callback):
         kw = {}
         kw.update(ex)
         callback(**kw)
     return 0
 def log_push_action(ui, repo, node, node_last, **kwargs):
     """
     Register that changes have been added to the repo - log the action *and* invalidate caches.
     Note: This hook is not only logging, but also the side effect invalidating
     caches! The function should perhaps be renamed.
@@ @@ -113,13 +111,12 @@ def log_push_action(ui, repo, node, node @@
     Called as Mercurial hook changegroup.kallithea_log_push_action .
     The pushed changesets is given by the revset 'node:node_last'.
     """
     revs = [ascii_str(repo[r].hex()) for r in mercurial.scmutil.revrange(repo, [b'%s:%s' % (node, node_last)])]
     process_pushed_raw_ids(revs)
     return 0
 def process_pushed_raw_ids(revs):
     """
     Register that changes have been added to the repo - log the action *and* invalidate caches.
@@ @@ -171,15 +168,13 @@ def log_create_repository(repository_dic @@
     callback = getattr(EXTENSIONS, 'CREATE_REPO_HOOK', None)
     if callable(callback):
         kw = {}
         kw.update(repository_dict)
         kw.update({'created_by': created_by})
         kw.update(kwargs)
         return callback(**kw)
     return 0
         callback(**kw)
 def check_allowed_create_user(user_dict, created_by, **kwargs):
     # pre create hooks
     from kallithea import EXTENSIONS
     callback = getattr(EXTENSIONS, 'PRE_CREATE_USER_HOOK', None)
@@ @@ -217,15 +212,13 @@ def log_create_user(user_dict, created_b @@
      'emails',
     """
     from kallithea import EXTENSIONS
     callback = getattr(EXTENSIONS, 'CREATE_USER_HOOK', None)
     if callable(callback):
         return callback(created_by=created_by, **user_dict)
     return 0
         callback(created_by=created_by, **user_dict)
 def log_delete_repository(repository_dict, deleted_by, **kwargs):
     """
     Post delete repository Hook.
@@ @@ -253,15 +246,13 @@ def log_delete_repository(repository_dic @@
     if callable(callback):
         kw = {}
         kw.update(repository_dict)
         kw.update({'deleted_by': deleted_by,
                    'deleted_on': time.time()})
         kw.update(kwargs)
         return callback(**kw)
     return 0
         callback(**kw)
 def log_delete_user(user_dict, deleted_by, **kwargs):
     """
     Post delete user Hook.
@@ @@ -289,15 +280,13 @@ def log_delete_user(user_dict, deleted_b @@
      'emails',
     """
     from kallithea import EXTENSIONS
     callback = getattr(EXTENSIONS, 'DELETE_USER_HOOK', None)
     if callable(callback):
         return callback(deleted_by=deleted_by, **user_dict)
     return 0
         callback(deleted_by=deleted_by, **user_dict)
 def _hook_environment(repo_path):
     """
     Create a light-weight environment for stand-alone scripts and return an UI and the
     db repository.
@@ @@ -327,19 +316,23 @@ def _hook_environment(repo_path): @@
     baseui = make_ui()
     return baseui, repo
 def handle_git_pre_receive(repo_path, git_stdin_lines):
     """Called from Git pre-receive hook"""
     """Called from Git pre-receive hook.
     The returned value is used as hook exit code and must be 0.
     """
     # Currently unused. TODO: remove?
     return 0
 def handle_git_post_receive(repo_path, git_stdin_lines):
     """Called from Git post-receive hook"""
     """Called from Git post-receive hook.
     The returned value is used as hook exit code and must be 0.
     """
     try:
         baseui, repo = _hook_environment(repo_path)
     except HookEnvironmentError as e:
         sys.stderr.write("Skipping Kallithea Git post-recieve hook %r.\nGit was apparently not invoked by Kallithea: %s\n" % (sys.argv[0], e))
         return 0
@@ @@ -396,10 +389,12 @@ def handle_git_post_receive(repo_path, g @@
     return 0
 # Almost exactly like Mercurial contrib/hg-ssh:
 def rejectpush(ui, **kwargs):
     """Mercurial hook to be installed as pretxnopen and prepushkey for read-only repos"""
     """Mercurial hook to be installed as pretxnopen and prepushkey for read-only repos.
     Return value 1 will make the hook fail and reject the push.
     """
     ex = get_hook_environment()
     ui.warn(safe_bytes("Push access to %r denied\n" % ex.repository))
     return 1

0 comments (0 inline, 0 general)