kallithea Changeset - 8759238d7356

Changeset - 8759238d7356

Parent rev.

Child rev.

[Not reviewed]

default

0 1 0

Mads Kiilerich (mads) - 6 years ago 2020-06-25 02:06:01
mads@kiilerich.com

db: refactor create_tables to try to make it more clear when existing databases are destroyed and created

1 file changed with 11 insertions and 16 deletions:

kallithea/lib/db_manage.py

0 comments (0 inline, 0 general)

kallithea/lib/db_manage.py

➞

Show inline comments

@@ @@ -71,30 +71,24 @@ class DbManage(object): @@
             engine = create_engine(self.dburi)
             init_model(engine)
             self.sa = Session()
     def create_tables(self):
         """
         Create a auth database
         Create database (optional) and tables.
         The database will be dropped (if it exists) and a new one created.
         """
         url = sqlalchemy.engine.url.make_url(self.dburi)
         database = url.database
         log.info("The existing database %r will be destroyed and created." % database)
         if not self.tests:
             if not self._ask_ok('Are you sure to destroy old database? [y/n]'):
                 print('Nothing done.')
                 sys.exit(0)
         log.info("Any existing database is going to be destroyed")
         if self.tests:
             destroy = True
         else:
             destroy = self._ask_ok('Are you sure to destroy old database ? [y/n]')
         if not destroy:
             print('Nothing done.')
             sys.exit(0)
         if destroy:
             # drop and re-create old schemas
             url = sqlalchemy.engine.url.make_url(self.dburi)
             database = url.database
             # Some databases enforce foreign key constraints and Base.metadata.drop_all() doesn't work
         if True:
             if url.drivername == 'mysql':
                 url.database = None  # don't connect to the database (it might not exist)
                 engine = sqlalchemy.create_engine(url)
                 with engine.connect() as conn:
                     conn.execute('DROP DATABASE IF EXISTS `%s`' % database)
                     conn.execute('CREATE DATABASE `%s` CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci' % database)
@@ @@ -104,12 +98,13 @@ class DbManage(object): @@
                 engine = sqlalchemy.create_engine(url)
                 with engine.connect() as conn:
                     conn.connection.set_isolation_level(ISOLATION_LEVEL_AUTOCOMMIT)
                     conn.execute('DROP DATABASE IF EXISTS "%s"' % database)
                     conn.execute('CREATE DATABASE "%s"' % database)
             else:
                 # Some databases enforce foreign key constraints and Base.metadata.drop_all() doesn't work, but this is
                 # known to work on SQLite - possibly not on other databases with strong referential integrity
                 Base.metadata.drop_all()
         Base.metadata.create_all(checkfirst=False)
         # Create an Alembic configuration and generate the version table,

0 comments (0 inline, 0 general)