kallithea Changeset - 9ead754dd0a4

Changeset - 9ead754dd0a4

Parent rev.

Child rev.

[Not reviewed]

default

0 1 0

Thomas De Schampheleire - 5 years ago 2020-11-07 21:49:39
thomas.de_schampheleire@nokia.com

model/user: 'body' parameter to NotificationModel().create() is unused so remove it

The email template for new user registration mails does not use the 'body'
parameter, so don't pass anything.

1 file changed with 1 insertions and 8 deletions:

kallithea/model/user.py

0 comments (0 inline, 0 general)

kallithea/model/user.py

➞

Show inline comments

@@ @@ -167,27 +167,20 @@ class UserModel(object): @@
         form_data['admin'] = False
         form_data['extern_type'] = db.User.DEFAULT_AUTH_TYPE
         form_data['extern_name'] = ''
         new_user = self.create(form_data)
         # notification to admins
         body = (
             'New user registration\n'
             '---------------------\n'
             '- Username: {user.username}\n'
             '- Full Name: {user.full_name}\n'
             '- Email: {user.email}\n'
             ).format(user=new_user)
         edit_url = webutils.canonical_url('edit_user', id=new_user.user_id)
         email_kwargs = {
             'registered_user_url': edit_url,
             'new_username': new_user.username,
             'new_email': new_user.email,
             'new_full_name': new_user.full_name}
         notification.NotificationModel().create(created_by=new_user,
-                                   body=body, recipients=None,
+                                   body=None, recipients=None,
                                    type_=notification.NotificationModel.TYPE_REGISTRATION,
                                    email_kwargs=email_kwargs)
     def update(self, user_id, form_data, skip_attrs=None):
         skip_attrs = skip_attrs or []
         user = self.get(user_id)

0 comments (0 inline, 0 general)