kallithea Changeset - 85135d4f9fef

Changeset - 85135d4f9fef

Parent rev.

Child rev.

[Not reviewed]

stable

0 1 0

Ross Thomas - 6 years ago 2020-02-12 14:37:15
ross@lns-nevasoft.com

Grafted from: 1be7d6b8d12c

ui: fix page navigation/scrolling when toggling "Follow" status

The onclick handler was a void function and thus not cancelling the default
handling of following the 'href'.

The called toggleFollowingRepo function was already returning false, so the
onClick handler just needs to return the result of the called function.

1 file changed with 1 insertions and 1 deletions:

kallithea/templates/base/base.html

0 comments (0 inline, 0 general)

kallithea/templates/base/base.html

➞

Show inline comments

@@ @@ -160,13 +160,13 @@ @@
               <li><a href="${h.url('search_repo',repo_name=c.repo_name)}"><i class="icon-search"></i>${_('Search')}</a></li>
               ## TODO: this check feels wrong, it would be better to have a check for permissions
               ## also it feels like a job for the controller
               %if request.authuser.username != 'default':
                   <li>
                    <a href="#" class="${'following' if c.repository_following else 'follow'}" onclick="toggleFollowingRepo(this, ${c.db_repo.repo_id});">
+                   <a href="#" class="${'following' if c.repository_following else 'follow'}" onclick="return toggleFollowingRepo(this, ${c.db_repo.repo_id});">
                     <span class="show-follow"><i class="icon-heart-empty"></i>${_('Follow')}</span>
                     <span class="show-following"><i class="icon-heart"></i>${_('Unfollow')}</span>
                    </a>
                   </li>
                   <li><a href="${h.url('repo_fork_home',repo_name=c.repo_name)}"><i class="icon-git-pull-request"></i>${_('Fork')}</a></li>
                   <li><a href="${h.url('pullrequest_home',repo_name=c.repo_name)}"><i class="icon-git-pull-request"></i>${_('Create Pull Request')}</a></li>

0 comments (0 inline, 0 general)