Changeset - ae81bcb8a93d
[Not reviewed]
default
0 3 0
Thomas De Schampheleire - 8 years ago 2018-02-06 21:34:48
thomas.de_schampheleire@nokia.com
HTML email templates: make pullrequest title a hyperlink

This commit makes the entirety of PR nice id _and_ PR title clickable,
rather than only the PR nice id.
3 files changed with 12 insertions and 24 deletions:
0 comments (0 inline, 0 general)
kallithea/templates/email_templates/pull_request.html
Show inline comments
 
@@ -22,8 +22,7 @@
 
            </div>
 
            <div>
 
                <a style="${link_style}"
 
                   href="${pr_url}">${pr_nice_id}</a>
 
                "<span style="color:${color_link}">${pr_title}</span>"
 
                   href="${pr_url}">${pr_nice_id} "${pr_title}"</a>
 
                ${_('by')}
 
                <span style="${data_style}">${pr_owner.full_name_and_username}</span>.
 
            </div>
kallithea/templates/email_templates/pull_request_comment.html
Show inline comments
 
@@ -30,8 +30,7 @@
 
            </div>
 
            <div>
 
                <a style="${link_style}"
 
                   href="${pr_url}">${pr_nice_id}</a>
 
                "<span style="color:${color_link}">${pr_title}</span>"
 
                   href="${pr_url}">${pr_nice_id} "${pr_title}"</a>
 
                ${_('by')}
 
                <span style="${data_style}">${pr_owner.full_name_and_username}</span>.
 
            </div>
kallithea/tests/models/test_dump_html_mails.ref.html
Show inline comments
 
@@ -969,8 +969,7 @@ View Pull Request: http://pr.org/7
 
            </div>
 
            <div>
 
                <a style="color:#395fa0;text-decoration:none"
 
                   href="http://pr.org/7">#7</a>
 
                "<span style="color:#395fa0">The Title</span>"
 
                   href="http://pr.org/7">#7 "The Title"</a>
 
                by
 
                <span style="border:#ddd 1px solid;background:#f9f9f9">u2 u3 (u2)</span>.
 
            </div>
 
@@ -1158,8 +1157,7 @@ View Pull Request: http://pr.org/7
 
            </div>
 
            <div>
 
                <a style="color:#395fa0;text-decoration:none"
 
                   href="http://pr.org/7">#7</a>
 
                "<span style="color:#395fa0">The Title</span>"
 
                   href="http://pr.org/7">#7 "The Title"</a>
 
                by
 
                <span style="border:#ddd 1px solid;background:#f9f9f9">u2 u3 (u2)</span>.
 
            </div>
 
@@ -1377,8 +1375,7 @@ View Comment: http://pr.org/comment
 
            </div>
 
            <div>
 
                <a style="color:#395fa0;text-decoration:none"
 
                   href="http://pr.org/7">#7</a>
 
                "<span style="color:#395fa0">The Title</span>"
 
                   href="http://pr.org/7">#7 "The Title"</a>
 
                by
 
                <span style="border:#ddd 1px solid;background:#f9f9f9">u2 u3 (u2)</span>.
 
            </div>
 
@@ -1542,8 +1539,7 @@ View Comment: http://pr.org/comment
 
            </div>
 
            <div>
 
                <a style="color:#395fa0;text-decoration:none"
 
                   href="http://pr.org/7">#7</a>
 
                "<span style="color:#395fa0">The Title</span>"
 
                   href="http://pr.org/7">#7 "The Title"</a>
 
                by
 
                <span style="border:#ddd 1px solid;background:#f9f9f9">u2 u3 (u2)</span>.
 
            </div>
 
@@ -1725,8 +1721,7 @@ View Comment: http://pr.org/comment
 
            </div>
 
            <div>
 
                <a style="color:#395fa0;text-decoration:none"
 
                   href="http://pr.org/7">#7</a>
 
                "<span style="color:#395fa0">The Title</span>"
 
                   href="http://pr.org/7">#7 "The Title"</a>
 
                by
 
                <span style="border:#ddd 1px solid;background:#f9f9f9">u2 u3 (u2)</span>.
 
            </div>
 
@@ -1908,8 +1903,7 @@ View Comment: http://pr.org/comment
 
            </div>
 
            <div>
 
                <a style="color:#395fa0;text-decoration:none"
 
                   href="http://pr.org/7">#7</a>
 
                "<span style="color:#395fa0">The Title</span>"
 
                   href="http://pr.org/7">#7 "The Title"</a>
 
                by
 
                <span style="border:#ddd 1px solid;background:#f9f9f9">u2 u3 (u2)</span>.
 
            </div>
 
@@ -2090,8 +2084,7 @@ View Comment: http://pr.org/comment
 
            </div>
 
            <div>
 
                <a style="color:#395fa0;text-decoration:none"
 
                   href="http://pr.org/7">#7</a>
 
                "<span style="color:#395fa0">The Title</span>"
 
                   href="http://pr.org/7">#7 "The Title"</a>
 
                by
 
                <span style="border:#ddd 1px solid;background:#f9f9f9">u2 u3 (u2)</span>.
 
            </div>
 
@@ -2272,8 +2265,7 @@ View Comment: http://pr.org/comment
 
            </div>
 
            <div>
 
                <a style="color:#395fa0;text-decoration:none"
 
                   href="http://pr.org/7">#7</a>
 
                "<span style="color:#395fa0">The Title</span>"
 
                   href="http://pr.org/7">#7 "The Title"</a>
 
                by
 
                <span style="border:#ddd 1px solid;background:#f9f9f9">u2 u3 (u2)</span>.
 
            </div>
 
@@ -2460,8 +2452,7 @@ View Comment: http://pr.org/comment
 
            </div>
 
            <div>
 
                <a style="color:#395fa0;text-decoration:none"
 
                   href="http://pr.org/7">#7</a>
 
                "<span style="color:#395fa0">The Title</span>"
 
                   href="http://pr.org/7">#7 "The Title"</a>
 
                by
 
                <span style="border:#ddd 1px solid;background:#f9f9f9">u2 u3 (u2)</span>.
 
            </div>
 
@@ -2648,8 +2639,7 @@ View Comment: http://pr.org/comment
 
            </div>
 
            <div>
 
                <a style="color:#395fa0;text-decoration:none"
 
                   href="http://pr.org/7">#7</a>
 
                "<span style="color:#395fa0">The Title</span>"
 
                   href="http://pr.org/7">#7 "The Title"</a>
 
                by
 
                <span style="border:#ddd 1px solid;background:#f9f9f9">u2 u3 (u2)</span>.
 
            </div>
0 comments (0 inline, 0 general)