kallithea Files · kallithea/templates/email_templates/changeset

Files @ d9fc7312177e

Branch filter:

Location: kallithea/kallithea/templates/email_templates/changeset_comment.html

d9fc7312177e 1.3 KiB text/html Show Annotation Show as Raw Download as Raw

Thomas De Schampheleire

HTML email templates: don't use link color for PR descriptions

The link color should only be used for actual hyperlinks.
Using it for anything else is very confusing for users.

For pullrequest mails, the usage of the link color for the PR description
may have been done to separate the description more clearly from the title
word 'Description' above it.
Instead, use a table with grey background similar to how comments are
displayed. This meets the objective of not abusing link colors as well as
clearly separating the description from the rest of the mail.

<%inherit file="main.html"/>\
\
<%block name="header">\
<% title = _('Mention in Comment on Changeset "%s"') % h.shorter(message, 200, firstline=True) if is_mention else _('Comment on Changeset "%s"') % h.shorter(message, 200, firstline=True) %>\
<%include file="header.html" args="title=title,link=cs_comment_url"/>\
</%block>\
\
<table cellpadding="0" cellspacing="0" border="0" width="100%">
    <tr>
        <td>
<%include file="comment.html" args="text=body,author=cs_comment_user,status=status_change"/>\
        </td>
    </tr>
    <tr>
        <td height="30px" style="height:30px"></td>
    </tr>
    <tr>
        <td>
            <div>
                ${_('Changeset on')}
                <a style="${link_style}"
                   href="${cs_target_repo}">${cs_target_repo}</a>
                ${_('branch')}
                <span style="color:${color_link}">${branch}</span>:
            </div>
            <div>
                "<a style="${link_style}"
                   href="${cs_url}">${h.shorter(message, 60, firstline=True)}</a>"
                ${_('by')}
                <span style="color:${color_link}">${cs_author.full_name_and_username}</span>.
            </div>
        </td>
    </tr>
    <tr>
        <td>
<%include file="button.html" args="url=cs_comment_url,title=_('View Comment'),padding_bottom=False"/>\
        </td>
    </tr>
</table>